qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE
Date: Thu, 31 Dec 2009 08:57:41 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 12/31/2009 03:01 AM, malc wrote:
>        lseek(fd, header_size, SEEK_SET);

Surprising that lseek's return value is not marked warn_unused_result.

Probably because it's guaranteed not to fail because of I/O errors:

ERRORS
       EBADF  fd is not an open file descriptor.

       EINVAL whence is not  one  of  SEEK_SET,  SEEK_CUR,  SEEK_END;
              or the resulting file offset would be negative, or
              beyond the end of a seekable device.

       EOVERFLOW
              The resulting file offset cannot be represented in an
              off_t.

       ESPIPE fd is associated with a pipe, socket, or FIFO.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]