[Qemu-devel] Re: [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

[Amit Shah]

On (Tue) Jan 05 2010 [10:27:19], Gerd Hoffmann wrote:
>   Hi,
>
>> +/* Guest wants to notify us of some event */
>> +static void handle_control_message(VirtIOSerial *vser, void *buf)
>> +{
>
>> +    cpkt->event = le16_to_cpu(cpkt->event);
>> +    cpkt->value = le16_to_cpu(cpkt->value);
>
> Does this modify guest memory?

Hm, I don't want to. I'll use a shadow struct.

>
>> +        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console, 1),
>
> virtser_bus_dev_print() prints this.  Properties are printed by "info  
> qtree" anyway, so you can drop that from virtser_bus_dev_print ...

I had to make is_console a property for other reasons; I'll remove it
from here.

                Amit