[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus |
Date: |
Tue, 5 Jan 2010 17:31:47 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Mon) Jan 04 2010 [14:46:58], Anthony Liguori wrote:
>
>> I'll annotate and read/write using the le format.
>
> Just use ldl_p and stl_p. (or ldw/stw as appropriate).
OK, I've switched to ldl/stl.
I'll send out the new series once the one I posted yesterday gets some
time on the list.
>>>> +static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int
>>>> indent)
>>>> +{
>>>> + VirtIOSerialDevice *dev = DO_UPCAST(VirtIOSerialDevice, qdev, qdev);
>>>> + VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,&dev->qdev);
>>>> +
>>>> + monitor_printf(mon, "%*s dev-prop-int: id: %u\n",
>>>> + indent, "", port->id);
>>>> + monitor_printf(mon, "%*s dev-prop-int: is_console: %d\n",
>>>> + indent, "", port->is_console);
>>>> +}
>>>
>>>
>>> This doesn't look used to me.
>>
>> It's helpful for debugging purposes, mostly: 'info qtree' on the monitor
>> will print this out and one can examine port state.
>
> Unused static functions will cause the build to fail with -Werror.
Oh, it's used alright:
static struct BusInfo virtser_bus_info = {
.name = "virtio-serial-bus",
.size = sizeof(VirtIOSerialBus),
.print_dev = virtser_bus_dev_print,
};
Amit