[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/6] PCI config space access overhaul
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 1/6] PCI config space access overhaul |
Date: |
Wed, 6 Jan 2010 00:16:37 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote:
> +typedef void (*pci_config_reg_fn)(PCIHostState *s, uint32_t config_reg,
> + PCIConfigAddress *conf);
> +
pci_decode_config_addr_fn would be a better name.
> struct PCIHostState {
> SysBusDevice busdev;
> + pci_config_reg_fn decode_config_reg;
> + PCIConfigAddress config_reg_dec;
decode_config_addr
and
config_addr
would be better names
> uint32_t config_reg;
> PCIBus *bus;
> };
>
> void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len);
> uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len);
> +void pci_host_init(PCIHostState *s);
> +void pci_host_decode_config_reg(PCIHostState *s, uint32_t config_reg,
> + PCIConfigAddress *decoded);
Shouldn't this be static?
And again, pci_host_decode_config_addr would be a better name IMO.
--
MST
- [Qemu-devel] [PATCH 4/6] Include dump of lspci -nn on real G5, (continued)
- [Qemu-devel] [PATCH 4/6] Include dump of lspci -nn on real G5, Alexander Graf, 2010/01/04
- [Qemu-devel] [PATCH 6/6] Enable secondary cmd64x, Alexander Graf, 2010/01/04
- [Qemu-devel] [PATCH 3/6] Use Mac99_U3 type on ppc64, Alexander Graf, 2010/01/04
- [Qemu-devel] [PATCH 2/6] Add config space conversion function for uni_north, Alexander Graf, 2010/01/04
- [Qemu-devel] [PATCH 5/6] Make interrupts work, Alexander Graf, 2010/01/04
- [Qemu-devel] [PATCH 1/6] PCI config space access overhaul, Alexander Graf, 2010/01/04
- [Qemu-devel] Re: [PATCH 1/6] PCI config space access overhaul,
Michael S. Tsirkin <=