[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines fro
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c |
|
Date: |
Wed, 06 Jan 2010 08:26:37 +0100 |
|
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Isaku Yamahata a écrit :
> On Tue, Jan 05, 2010 at 11:11:00PM +0100, Aurelien Jarno wrote:
>> On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote:
>>> Split out pc smbus routines from acpi.c into pc_smbus.c and
>>> use it.
>> Given the code is not specific to PC, but is also used on MIPS, I am not
>> sure pc_smbus is the best name.
>
> Okay. I'll drop pc_ prefix. (for both file name and function names).
> Do you also want similar to pc_apm.c in the next patch?
>
Yes, it looks better to me.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH V11 20/27] rtc: make rtc_xxx accept/return ISADevice instead of RTCState., (continued)
- [Qemu-devel] [PATCH V11 20/27] rtc: make rtc_xxx accept/return ISADevice instead of RTCState., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 15/27] pc: split out vga initialization from pc_init1() into pc_vga_init()., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 12/27] pc: make pc_init1() not refer ferr_irq directly., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 14/27] pc: split out memory allocation from pc_init1() into pc_memory_init(), Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 03/27] acpi: add acpi constants from linux header files and use them., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 02/27] acpi: split out apm register emulation from acpi.c, Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 06/27] pc: initialize ioapic before use., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c, Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 22/27] pci hotplug: add argument to pci hot plug callback., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 27/27] mc146818rtc: remove #ifdef DEBUG_CMOS., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 09/27] pc: remove a global variable, floppy_controller., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 11/27] pc: introduce a function to allocate cpu irq., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 26/27] pc_apm: remove #ifdef DEBUG., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 19/27] pc: move rtc declarations from pc.h into a dedicated header file., Isaku Yamahata, 2010/01/05
- [Qemu-devel] [PATCH V11 25/27] acpi_piix4: remove #ifdef DEBUG., Isaku Yamahata, 2010/01/05