Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of TFTP

[Anthony Liguori]

On 01/06/2010 04:11 PM, Milan Plzik wrote:
>    Hello,
>
>    according to RFC 1350 and RFC 2347, TFTP server should answer RRQ by
> either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with
> additional options by sending both OACK and DATA packet, thus breaking
> the "lock-step" feature of the protocol, and also confuses client.
>
>    Proposed solution would be to, in case of OACK packet, wait for ACK
> from client and just then start sending data. Attached patch implements
> this.
>
>    I would like to thank to mbc and th1 (who is the rightful author of
> the patch) from #gpxe for their time, effort and patience with me :)
>    

Thanks for the patch, I assume this fixes -boot n when using -bootp and 
-tftp.  Can you add an appropriate Signed-off-by and resubmit?

Regards,

Anthony Liguori

>         Milan Plzik
>