[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf |
Date: |
Thu, 7 Jan 2010 18:59:42 +0200 |
On Thu, Jan 07, 2010 at 10:53:30AM -0600, Anthony Liguori wrote:
> On 01/07/2010 10:15 AM, Gleb Natapov wrote:
> >>KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always
> >>been present in kvm_para.h. Since we include kvm_para.h
> >>unconditionally, there's no way we wouldn't have
> >>KVM_CPUID_SIGNATURE.
> >>
> >It is there in qemu-kvm and we suppose to bring knowledge from there :)
>
> Hopefully just the good bits.
>
> >But I can drop it if you like.
>
> I don't want to deviate unnecessarily from qemu-kvm so we can
> approach this in one of two ways. We can remove the guard in
> qemu-kvm and Avi can send me a pull request with this feature. I
> can also just pull in the patch as-is and we can fix this in both
> places later. I'm happy either way.
>
Actually qemu-kvm doesn't uses this function right now. It has it's own
version in qemu-kvm-x86.c. The idea was to teach qemu-kvm to use
upstream function instead.
--
Gleb.
- [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Anthony Liguori, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Anthony Liguori, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Avi Kivity, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Anthony Liguori, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/07
- Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf,
Gleb Natapov <=
[Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/07
Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/12
Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf, Avi Kivity, 2010/01/12
Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf, Avi Kivity, 2010/01/12
[Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf, Gleb Natapov, 2010/01/13