Re: [Qemu-devel] [PATCH] write option roms in pc-bios/

[Anthony Liguori]

On 12/24/2009 08:27 AM, Paolo Bonzini wrote:
> > > The gdt address calculation in linuxboot.bin is broken in two ways: first
> > > it loads %cs into %eax, but that instruction leaves the high bits of %eax
> > > undefined and we did not clear them. Secondly, we completely ignore the
> > > incorrect %eax, and use the undefined %ebx instead.
> > >
> > > With these issues fixed, linuxboot works again.
> > >        
> > Wow, I wonder how it worked for me...
> >      
> Got it.  The option roms are built in pc-bios/optionrom, but QEMU loads
> the ones in pc-bios.  So actually I was always testing Alexander's code
> even though I had done a "make -B" to feel safer. :-(
>
> Signed-off-by: Paolo Bonzini<address@hidden>
>    

This will wreak havoc on the tree since these are built by default and 
they are replacing files in revision control.

Regards,

Anthony Liguori