Re: [Qemu-devel] [PATCH] dmg: fix ->open failure

[Christoph Hellwig]

On Mon, Jan 11, 2010 at 02:43:59PM +0100, Kevin Wolf wrote:
> Am 11.01.2010 14:06, schrieb Christoph Hellwig:
> > 
> > Currently the dmg image format driver simply opens the images as raw
> > if any kind of failure happens.  This is contrarty to the behaviour
> > of all other image formats which just return an error and let the
> > block core deal with it.
> > 
> > Signed-off-by: Christoph Hellwig <address@hidden>
> 
> Acked-by: Kevin Wolf <address@hidden>
> 
> I mean looking at the patched code I see lots of things that are wrong,
> but they are all unrelated to your change: There are error cases where
> memory is leaked, and it should use bdrv_* functions instead of the
> native open/read/etc. And obviously coding style is completely off (most
> annoying: tabs!)

Yes, the code pretty much is a mess, but I didn't really want to touch
it.  I just looked into picking up your search host_ for raw patches and
was looking for all the block image driver functionality in the tree.

> 
> Kevin
---end quoted text---