qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
Date: Tue, 12 Jan 2010 10:42:54 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0

On 01/11/2010 09:18 PM, Anthony Liguori wrote:
On 01/07/2010 10:24 AM, Gleb Natapov wrote:
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 4084503..6a841de 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -17,6 +17,7 @@
  #include<sys/mman.h>

  #include<linux/kvm.h>
+#include<linux/kvm_para.h>

This breaks the build on a default F12 install because while kvm.h is present, kvm_para.h is not. This is a hard one to fix.

We can default the kvm search path to /lib/modules/$(uname -r)/build, we can fix the glibc headers and live with it, or we can pull in the kvm headers into qemu.

Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?


Two options:

- make kvm detection depend on kvm_para.h being includable, fix all relevant distro kernels to supply it, and live with the breakage - add a new CONFIG_KVM_PARA, detect it at configure time, and only include it if present

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]