[Qemu-devel] Re: [PATCHv7 3/3] virtio: add features as qdev properties

[Michael S. Tsirkin]

On Tue, Jan 12, 2010 at 06:05:54PM +0100, Gerd Hoffmann wrote:
>   Hi,
>
>> +#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
>> +        DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
>> +        DEFINE_PROP_BIT("csum", _state, _field, VIRTIO_NET_F_CSUM, true), \
>> +        DEFINE_PROP_BIT("guest_csum", _state, _field, 
>> VIRTIO_NET_F_GUEST_CSUM, true), \
>> +        DEFINE_PROP_BIT("mac", _state, _field, VIRTIO_NET_F_MAC, true), \
>
> Didn't noticed in review, sorry.  This isn't going to work as all  
> network cards already have a 'mac' property to set the mac address.  Try  
> to create a virtio nic with a non-default mac address and watch qemu 
> fail.
>
> cheers,
>   Gerd

Fixed, thanks!