[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes |
Date: |
Tue, 12 Jan 2010 21:16:59 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
Without this fix, guest crashes with drive=virtio.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
Anthony, could you please apply this patch quickly?
It's an obvious one and it fixes guest crashes.
Also, sorry about missing this in my testing.
hw/qdev-properties.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9e123ae..277ff9e 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -20,7 +20,7 @@ static void bit_prop_set(DeviceState *dev, Property *props,
bool val)
uint32_t *p = qdev_get_prop_ptr(dev, props);
uint32_t mask = qdev_get_prop_mask(props);
if (val)
- *p |= ~mask;
+ *p |= mask;
else
*p &= ~mask;
}
--
1.6.6.rc1.43.gf55cc
- [Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes,
Michael S. Tsirkin <=