qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] QMP: Don't free async event's 'data'


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] QMP: Don't free async event's 'data'
Date: Tue, 12 Jan 2010 13:35:18 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/08/2010 12:45 PM, Luiz Capitulino wrote:
The monitor_protocol_event() function will free the
event's data, this is wrong as 'data' management is up
to the caller.

Signed-off-by: Luiz Capitulino<address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori

---
  monitor.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/monitor.c b/monitor.c
index 3af1d5c..2403a97 100644
--- a/monitor.c
+++ b/monitor.c
@@ -365,8 +365,10 @@ void monitor_protocol_event(MonitorEvent event, QObject 
*data)
      qmp = qdict_new();
      timestamp_put(qmp);
      qdict_put(qmp, "event", qstring_from_str(event_name));
-    if (data)
+    if (data) {
+        qobject_incref(data);
          qdict_put_obj(qmp, "data", data);
+    }

      monitor_json_emitter(mon, QOBJECT(qmp));
      QDECREF(qmp);





reply via email to

[Prev in Thread] Current Thread [Next in Thread]