Re: [Qemu-devel] [PATCH 9/9] PPC: Add USB per default on U3

[Alexander Graf]

On 12.01.2010, at 22:54, Andreas Färber wrote:

> 
> Am 12.01.2010 um 12:58 schrieb Alexander Graf:
> 
>> Linux with CONFIG_PPC64 doesn't support ADB devices anymore, so we have to
>> use USB for keyboard and mouse.
>> 
>> This patch enables USB per default on U3 and adds a virtual keyboard and 
>> mouse
>> there.
> 
> Wasn't the PowerMac G3 blue&white (Yosemite) the first New World Mac? It had 
> a USB keyboard and mouse and ADB for backwards compatibility.
> 
>> diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
>> index c08211e..52a56e4 100644
>> --- a/hw/ppc_newworld.c
>> +++ b/hw/ppc_newworld.c
> 
>> @@ -353,12 +354,14 @@ static void ppc_core99_init (ram_addr_t ram_size,
>>    ide_mem_index[2] = pmac_ide_init(hd, pic[0x0e], dbdma, 0x1a, pic[0x02]);
>> 
>>    /* cuda also initialize ADB */
>> +    if (machine_arch == ARCH_MAC99_U3) {
>> +        usb_enabled = 1;
>> +    }
> 
> I'd therefore propose to enable USB independently of U3 for the New World 
> machine.

Well USB comes with quite some overhead, so I'd like to only enable it only 
when necessary. On the U3 it is necessary, because we don't get a keyboard 
otherwise. On PPC32 Macs we can just not have USB and be happy.

Alex