[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] versatile_pci: user PCIHostState instead of
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] versatile_pci: user PCIHostState instead of PCIBus |
|
Date: |
Wed, 13 Jan 2010 15:04:57 +0200 |
|
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Jan 13, 2010 at 01:02:50PM +0000, Paul Brook wrote:
> On Tuesday 12 January 2010, Isaku Yamahata wrote:
> > To use pci host framework, use PCIHostState instead of PCIBus in
> > PCIVPBState.
>
> No.
>
> pci_host.[ch] provides very specific functionality, it is not a generic PCI
> host device. Specifically it provides indirect access to PCI config space via
> a memory mapped {address,data} pair. The versatile PCI host exposes PCI
> config
> space directly, so should not be using this code.
>
> If you want a generic framework for PCI hosts then you need to use something
> else. If nothing else, assuming that a PCI host bridge is always is SysBus
> device is wrong.
>
> Paul
What most people seem to want is callback that will get length is a
parameter instead of supplying 3 functions. pci_host does it
but we do not need pci_host for this.
--
MST
- Re: [Qemu-devel] Re: [PATCH 6/6] pci host: make pci_data_{write, read}() get PCIConfigAddress., (continued)
[Qemu-devel] [PATCH 4/6] pci_host: remove code duplication in pci_host_template.h, Isaku Yamahata, 2010/01/12
[Qemu-devel] [PATCH 2/6] sh_pci: s/sh_pci_data_write/sh_pci_mem_write/g for consistency., Isaku Yamahata, 2010/01/12
[Qemu-devel] [PATCH 1/6] sh_pci: use PCIHostState instead of PCIBus., Isaku Yamahata, 2010/01/12
[Qemu-devel] [PATCH 3/6] versatile_pci: user PCIHostState instead of PCIBus, Isaku Yamahata, 2010/01/12
[Qemu-devel] Re: [PATCH 0/6] pci: pci_data_{write, read}() clean up, Michael S. Tsirkin, 2010/01/12