[Qemu-devel] Re: [PATCH v0 0/8]: VNC events and cleanup

[Daniel P. Berrange]

On Thu, Jan 14, 2010 at 02:50:51PM -0200, Luiz Capitulino wrote:
>  Hi there,
> 
>  This series contains two VNC related changes. First a small cleanup
> is done in the current 'query-vnc' command _response_, then the following
> QMP events are introduced:
> 
> - VNC_CONNECTED: emitted when a VNC client establishes a connection
> - VNC_INITIALIZED: emitted when the VNC session is made active
> - VNC_DISCONNECTED: emitted when the conection is closed
> 
>  The only issue is the current events documentation. I'm using the
> current format which is quite bad, things will improve when we have
> proper documentation support (being worked out by Markus).

This series looks reasonable to me wrt VNC.

Should we try to think about what we'll do with other network services ?
eg will we add SPICE_CONNECTED / SPICE_DISCONNECTED in the future ?
Similar question for chardevs using networking ?


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|