[Qemu-devel] Re: [PATCH v0 0/8]: VNC events and cleanup

[Luiz Capitulino]

On Thu, 14 Jan 2010 17:32:14 +0000
"Daniel P. Berrange" <address@hidden> wrote:

> On Thu, Jan 14, 2010 at 02:50:51PM -0200, Luiz Capitulino wrote:
> >  Hi there,
> > 
> >  This series contains two VNC related changes. First a small cleanup
> > is done in the current 'query-vnc' command _response_, then the following
> > QMP events are introduced:
> > 
> > - VNC_CONNECTED: emitted when a VNC client establishes a connection
> > - VNC_INITIALIZED: emitted when the VNC session is made active
> > - VNC_DISCONNECTED: emitted when the conection is closed
> > 
> >  The only issue is the current events documentation. I'm using the
> > current format which is quite bad, things will improve when we have
> > proper documentation support (being worked out by Markus).
> 
> This series looks reasonable to me wrt VNC.
> 
> Should we try to think about what we'll do with other network services ?
> eg will we add SPICE_CONNECTED / SPICE_DISCONNECTED in the future ?
> Similar question for chardevs using networking ?

 That's a good question, you think they should converge some way?

 If the chardev API can tell that a fd belongs to a certain subsystem,
then maybe we could move the machinery of connected/disconnected events
down there.

 But that's only an internal refactoring, at first I think we'll have
to add different events for each subsystem we're interested in.