qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: paramet

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter
Date: Mon, 18 Jan 2010 10:24:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 
On 01/15/10 21:07, Jan Kiszka wrote:

The missing '@' broke 'udp::<port>@:<port>' parsing.



          if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<  2) {
              host[0] = 0;
-            if (sscanf(p, ":%32[^,]%n", port,&pos)<  1) {
+            if (sscanf(p, ":%32[^@,]%n", port,&pos)<  1) {


Indeed.


                  fprintf(stderr, "udp #1\n");


While you are at it, can you also zap this debug leftover?

thanks,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]