[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: paramet
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter |
|
Date: |
Mon, 18 Jan 2010 11:21:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Gerd Hoffmann wrote:
> On 01/15/10 21:07, Jan Kiszka wrote:
>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>
>> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) {
>> host[0] = 0;
>> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) {
>> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) {
>
> Indeed.
>
>> fprintf(stderr, "udp #1\n");
>
> While you are at it, can you also zap this debug leftover?
Looks like there are three of them in qemu_chr_parse_compat - kill them all?
Jan
signature.asc
Description: OpenPGP digital signature