[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] QError: New QERR_FOPEN_FAILED
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] QError: New QERR_FOPEN_FAILED |
Date: |
Mon, 18 Jan 2010 14:49:51 -0200 |
On Mon, 18 Jan 2010 15:52:13 +0100
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > On Fri, 15 Jan 2010 17:25:25 +0100
> > Markus Armbruster <address@hidden> wrote:
> >
> >>
> >> Signed-off-by: Markus Armbruster <address@hidden>
> >> ---
> >> qerror.c | 4 ++++
> >> qerror.h | 3 +++
> >> 2 files changed, 7 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/qerror.c b/qerror.c
> >> index 5f8fc5d..e7b8ca7 100644
> >> --- a/qerror.c
> >> +++ b/qerror.c
> >> @@ -73,6 +73,10 @@ static const QErrorStringTable qerror_table[] = {
> >> .desc = "No file descriptor supplied via SCM_RIGHTS",
> >> },
> >> {
> >> + .error_fmt = QERR_FOPEN_FAILED,
> >> + .desc = "Could not open '%{filename}'",
> >> + },
> >
> > Shouldn't this be something like QERR_OPEN_FAILED, so that we
> > can use the same error for all open functions?
>
> Whatever name you like best. The intention is certainly to use this for
> *file* open errors regardless of the precise function used to open.
Probably OpenFileFailed or CantOpenFile.
> > Also, we have to think a way to specify the reason from errno.
>
> Yes only if client programs use this for handling the error, not just to
> pass it to a human user.
>
> Although most errors are standardized, their numeric encoding is not, so
> we can't just transmit errno. strerror() is right out, because that's
> for humans.
IIRC we had a conversation about this and the conclusion was that we
will need our own qerror_strerror() or something like that.
- [Qemu-devel] [PATCH 0/6] Convert memsave, pmemsave, cpu to QObject+QError, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 4/6] monitor: convert do_physical_memory_save() to QError, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 5/6] QError: New QERR_INVALID_CPU_INDEX, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 6/6] monitor: convert do_cpu_set() to QObject, QError, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 1/6] monitor: Don't check for mon_get_cpu() failure, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 3/6] monitor: convert do_memory_save() to QError, Markus Armbruster, 2010/01/15
- [Qemu-devel] [PATCH 2/6] QError: New QERR_FOPEN_FAILED, Markus Armbruster, 2010/01/15