[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table |
|
Date: |
Tue, 19 Jan 2010 11:58:43 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote:
> Return the appropriate error value instead of always using EIO. Don't free the
> L1 table on errors, we still need it.
>
> Signed-off-by: Kevin Wolf <address@hidden>
Looks good correct, but shouldn't we free the clusters for the new l1
table if writing to it fails? At least dependend on whether it's EIO
in which case we could assume the sectos on disk to be worn out.