Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

[malc]

On Tue, 19 Jan 2010, Richard Henderson wrote:

> On 01/19/2010 12:47 AM, identifier scorpio wrote:
> > I ported TCG to alpha platform, the patch is currently based on stable-0.10
> > branch,
> > and now it can run linux-0.2.img testing image on my alpha XP1000
> > workstation.
> > but it still can't run MS-windows, and I hope someone, especially those guys
> > that
> > are working on target-alpha, may help me to find the bugs.
> 
> Your patch is mangled.  If you can't use sendmail directly, then attach the
> patch.

[..snip..]

> > +/*
> > + * mov 64-bit immediate 'arg' to regsiter 'Ra'. this function will
> > + * generate variable length of target insn sequence.
> > +*/
> > +static inline void tcg_out_movi( \
> > +    TCGContext *s, TCGType type, int Ra, tcg_target_long arg)
> > +{
> > +    if (type == TCG_TYPE_I32) {
> > +        if ( arg != (int32_t)arg)
> > +            tcg_abort();
> 
> Well that's most likely a bug.  If I32 then I'd consider the high bits
> garbage.  I don't recall any promise that TCG sign-extends 32-bit inputs.

They are garbage, see f.e. 591d6f1dfdb60ab0a4cc487cd5781fa799dcac4b

[..snip..]

> 
> 
> r~
> 

Thanks for reviewing it!

-- 
mailto:address@hidden