[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/17] check pipe() return value
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 14/17] check pipe() return value |
Date: |
Wed, 20 Jan 2010 00:56:21 +0100 |
Signed-off-by: Juan Quintela <address@hidden>
---
hw/xen_domainbuild.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c
index 20d731d..2f59856 100644
--- a/hw/xen_domainbuild.c
+++ b/hw/xen_domainbuild.c
@@ -156,15 +156,18 @@ quit:
return;
}
-static void xen_domain_watcher(void)
+static int xen_domain_watcher(void)
{
int qemu_running = 1;
int fd[2], i, n, rc;
char byte;
- pipe(fd);
+ if (pipe(fd) != 0) {
+ qemu_log("%s: Huh? pipe error: %s\n", __FUNCTION__, strerror(errno));
+ return -1;
+ }
if (fork() != 0)
- return; /* not child */
+ return 0; /* not child */
/* close all file handles, except stdio/out/err,
* our watch pipe and the xen interface handle */
@@ -238,7 +241,9 @@ int xen_domain_build_pv(const char *kernel, const char
*ramdisk,
}
qemu_log("xen: created domain %d\n", xen_domid);
atexit(xen_domain_cleanup);
- xen_domain_watcher();
+ if (xen_domain_watcher() == -1) {
+ goto err;
+ }
xenstore_domain_init1(kernel, ramdisk, cmdline);
--
1.6.5.2
[Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 11/17] vl.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 12/17] monitor.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 10/17] usb-linux.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 13/17] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 14/17] check pipe() return value,
Juan Quintela <=
[Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all, Juan Quintela, 2010/01/19
[Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error, Juan Quintela, 2010/01/19