|
| From: | Jamie Lokier |
| Subject: | Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE. |
| Date: | Wed, 20 Jan 2010 02:05:43 +0000 |
| User-agent: | Mutt/1.5.13 (2006-08-11) |
Michael S. Tsirkin wrote: > On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: > > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have > > BDRV_DONT_SNAPSHOT, either. > > Well, this just mirros the file access macros: we have RDONLY, WRONLY > and RDRW. I assume this similarity is just historical? To avoid confusion, why don't we just call the flag BDRV_O_WRITABLE. Then it's obvious what clearing that flag means. -- Jamie
| [Prev in Thread] | Current Thread | [Next in Thread] |