|
| From: | Markus Armbruster |
| Subject: | Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE. |
| Date: | Wed, 20 Jan 2010 08:26:56 +0100 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jamie Lokier <address@hidden> writes: > Michael S. Tsirkin wrote: >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have >> > BDRV_DONT_SNAPSHOT, either. >> >> Well, this just mirros the file access macros: we have RDONLY, WRONLY >> and RDRW. I assume this similarity is just historical? > > To avoid confusion, why don't we just call the flag BDRV_O_WRITABLE. > Then it's obvious what clearing that flag means. Sounds good to me.
| [Prev in Thread] | Current Thread | [Next in Thread] |