[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject |
|
Date: |
Wed, 20 Jan 2010 18:57:56 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> Hi,
>
> This new version addresses Markus's comments.
>
> changelog
> ---------
>
> V1 -> V2
>
> - Make class_info's key 'desc' optional
> - Better indentation
> - Doc fixes
>
> V0 -> V1
>
> - Coding style fixes
> - Make 'BAR' and 'IRQ' keys lowercase
> - Add 'irq' key to the documentation
>
> Thanks.
Looks good, although one comment still applies: PATCH 3/5 regresses info
pci, 4/5 and 5/5 fix it. Do we care? They're separate because they're
untested.
- [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject, Luiz Capitulino, 2010/01/20
- [Qemu-devel] [PATCH 1/5] QList: Introduce QLIST_FOREACH_ENTRY(), Luiz Capitulino, 2010/01/20
- [Qemu-devel] [PATCH 2/5] QDict: Introduce qdict_get_qdict(), Luiz Capitulino, 2010/01/20
- [Qemu-devel] [PATCH 3/5] PCI: Convert pci_info() to QObject, Luiz Capitulino, 2010/01/20
- [Qemu-devel] [PATCH 4/5] PCI: do_pci_info(): PCI bridge support, Luiz Capitulino, 2010/01/20
- [Qemu-devel] [PATCH 5/5] PCI: do_pci_info(): PCI bridge devices support, Luiz Capitulino, 2010/01/20
- Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject,
Markus Armbruster <=