Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

[Luiz Capitulino]

On Wed, 20 Jan 2010 18:57:56 +0100
Markus Armbruster <address@hidden> wrote:

> Luiz Capitulino <address@hidden> writes:
> 
> >  Hi,
> >
> >  This new version addresses Markus's comments.
> >
> > changelog
> > ---------
> >
> > V1 -> V2
> >
> > - Make class_info's key 'desc' optional
> > - Better indentation
> > - Doc fixes
> >
> > V0 -> V1
> >
> > - Coding style fixes
> > - Make 'BAR' and 'IRQ' keys lowercase
> > - Add 'irq' key to the documentation
> >
> >  Thanks.
> 
> Looks good, although one comment still applies: PATCH 3/5 regresses info
> pci, 4/5 and 5/5 fix it.  Do we care?  They're separate because they're
> untested.

 There are two problems here, which apply for those whom emulate
the hardware:

1. 'info pci' output will brake with git bisect

2. As the code is untested, it might be broken

 Only two 2 seems serious.

 Michael, does the sparc image on qemu.org have the hardware
in question (pci bridge)?