[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Stop using "which" in ./configure
From: |
Måns Rullgård |
Subject: |
[Qemu-devel] Re: Stop using "which" in ./configure |
Date: |
Thu, 21 Jan 2010 12:14:40 +0000 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.22 (Instant Classic, linux) |
Juan Quintela <address@hidden> writes:
> Loïc Minier <address@hidden> wrote:
>> On Wed, Jan 20, 2010, Måns Rullgård wrote:
>>> If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>>> Likewise if you set the value first.
>>
>> Ok; see attached patches
>
> I still think that path_of is a complication that we don't really need.
>
> "type" command exist in posix, and althought its output is not defined,
> if the output of a real command don't show the path that we need (in
> this case /usr/bin/install), then type is pretty wrong in my humble
> opinion.
I think that entire test is wrong, in fact. It is perfectly possible
for someone on Solaris to install a working "install" command in
/usr/bin. It is better, if possible, to test whatever "install"
command is in the path, and complain only if it actually fails.
--
Måns Rullgård
address@hidden
- Re: [Qemu-devel] Stop using "which" in ./configure, (continued)
- Re: [Qemu-devel] Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/19
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure, Juan Quintela, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure,
Måns Rullgård <=
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/26
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/26
- [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has(), Loïc Minier, 2010/01/27
- Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it, Ben Taylor, 2010/01/27
- [Qemu-devel] Re: [PATCH 1/3] Check for sdl-config before calling it, Paolo Bonzini, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/28