|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to specify path to configuration files (v3) |
Date: | Sun, 24 Jan 2010 09:23:03 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 01/24/2010 08:45 AM, Paolo Bonzini wrote:
On 01/24/2010 03:22 PM, Anthony Liguori wrote:The default value is ${prefix}/etc/qemu. --sysconfdir can be used to override the default to an absolute path. The expectation is that when installed to/usr, --sysconfdir=/etc/qemu will be used. Signed-off-by: Anthony Liguori<address@hidden> --- v2 -> v3 - default sysconfdir to ${prefix}/etc on unix, ${prefix} on win32 - set confdir to ${sysconfdir}/qemu on unix, ${sysconfdir} on win32I'm not sure about the choice for Windows. Do we want possibly a dozen of .conf files all in the same directory as the binaries, or maybe it's better to set sysconfdir = ${prefix}/conf, confdir=${sysconfdir} on Windows?
I honestly don't know. What's the normal thing to do with Windows?
+if test "$mingw32" = "yes" ; then + echo "CONFIG_QEMU_CONFDIR=\"$sysconfdir\"" >> $config_host_mak +else + echo "CONFIG_QEMU_CONFDIR=\"${sysconfdir}/qemu\"" >> $config_host_mak +fiAlso, here you can use $confsuffix as used a bit above to avoid introducing an if here.Anyway, this can be discussed/cleaned up later, this patch gets my ack.
Regards, Anthony Liguori
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |