[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] Try not to exceed max downtime on stage3
From: |
Liran Schour |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] Try not to exceed max downtime on stage3 |
Date: |
Mon, 25 Jan 2010 10:57:13 +0200 |
Pierre Riteau <address@hidden> wrote on 21/01/2010 20:03:32:
> On 21 janv. 2010, at 16:24, Liran Schour wrote:
>
> > Move to stage3 only when remaining work can be done below max downtime.
> >
> > Changes from v1: remove max iterations. Try to infer storage
> performance and by that calculate remaining work.
...
>
> I haven't read the patch in detail but I think we should be able to
> avoid duplicating code from vl.c by using qemu_get_clock.
> Also, is floating point really necessary?
I thought that qemu_get_clock will return a value in 1000HZ (and that is
too low resolution). But now I see that I can use qemu_get_clock
(host_clock) and get nanoseconds resolution. I will switch it to
qemu_get_clock(host_clock) to avoid duplicating of code.
And I think we can avoid floating point here.
Thanks for the review,
- Liran
Re: [Qemu-devel] [PATCH v2 0/4] Reduce down time during migration without shared storage, Pierre Riteau, 2010/01/25