[Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support

[Luiz Capitulino]

On Sun, 24 Jan 2010 12:36:39 +0200
Avi Kivity <address@hidden> wrote:

> On 01/21/2010 11:09 PM, Luiz Capitulino wrote:
> > This commit disables asynchronous messages by default and
> > introduces two new QMP commands: async_msg_enable and
> > async_msg_disable.
> >
> > Each QMP Monitor has its own set of asynchronous messages,
> > so for example, if QEMU is run with two QMP Monitors async
> > messages setup in one of them doesn't affect the other.
> >
> > To implement this design a bitmap is introduced to the
> > Monitor struct, each async message is represented by one bit.
> >
> >    
> 
> A bitmap is an overkill here, an array of booleans should suffice.

 Ok.

> > +#define EVENTS_BITMAP_SIZE (QEVENT_MAX / 8)
> >    
> 
> Doesn't that underflow if QEVENT_MAX is not a multiple of 8?

 Yes.