[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/7] Revert "qdev: Add help for device properties"
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 4/7] Revert "qdev: Add help for device properties" |
Date: |
Fri, 29 Jan 2010 19:48:59 +0100 |
This reverts commit 2ba6edf0dd740166632df80caa85992b20791a68.
The commit has two issues:
* When it runs from the monitor, e.g. "device_add e1000,?", it prints
to stderr instead of the monitor.
* Help looks to callers just like failed device creation. This makes
main() exit unsuccessfully on "-device e1000,?".
We need to do this differently.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/qdev-properties.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 8547ad2..277ff9e 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -544,19 +544,8 @@ int qdev_prop_parse(DeviceState *dev, const char *name,
const char *value)
prop = qdev_prop_find(dev, name);
if (!prop) {
- if (strcmp(name, "?") != 0) {
- fprintf(stderr, "property \"%s.%s\" not found\n",
- dev->info->name, name);
- } else {
- fprintf(stderr, "supported properties:\n");
- if (dev->info->props != NULL) {
- Property *props = dev->info->props;
- while (props->name) {
- fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
- props++;
- }
- }
- }
+ fprintf(stderr, "property \"%s.%s\" not found\n",
+ dev->info->name, name);
return -1;
}
if (!prop->info->parse) {
--
1.6.6
- [Qemu-devel] [PATCH 0/7] Clean up -device help, Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 1/7] qemu-option: Make qemu_opts_foreach() accumulate return values, Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 5/7] qdev: Add help for device properties, Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 3/7] Revert "qdev: Add help for property value", Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 2/7] qdev: Fix exit code for -device ?, Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 4/7] Revert "qdev: Add help for device properties",
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/7] qdev: update help on -device, Markus Armbruster, 2010/01/29
- [Qemu-devel] [PATCH 7/7] qdev: Add rudimentary help for property value, Markus Armbruster, 2010/01/29