[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] block: Enable fall-back to read-only for ba
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH] block: Enable fall-back to read-only for backing file |
|
Date: |
Mon, 1 Feb 2010 10:06:49 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Mon, Feb 01, 2010 at 09:46:00AM +0100, Kevin Wolf wrote:
> > Is it better to always open the backing file with read-only mode ? this
> > will be more consistent/predictable ?
>
> I would love to open them read-only unconditionally, but we can't. It
> would break the commit monitor command. I think the read-only fallback
> is appropriate for backing files.
The clean way would be to require an explicit BACKING_WRITEABLE flag
if we want to commit to it. But I suspect it's too late to refit that
now.