[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command |
Date: |
Mon, 1 Feb 2010 16:11:27 -0200 |
On Mon, 01 Feb 2010 18:04:04 +0100
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > It will be used to switch between "handshake" and "operational"
> > modes. Currently it doesn't have any practical effect, as
> > mode-oriented support is not enforced yet.
> >
> > Usage example:
> >
> > { "execute": "qmp_switch_mode", "arguments": { "mode": "operational" } }
> >
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > monitor.c | 26 ++++++++++++++++++++++++++
> > qemu-monitor.hx | 15 +++++++++++++++
> > 2 files changed, 41 insertions(+), 0 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index 3ced51d..f6dd64d 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -704,6 +704,32 @@ static void do_info_qmp_mode(Monitor *mon, QObject
> > **ret_data)
> > *ret_data = qobject_from_jsonf("{ 'mode': %s }", mode);
> > }
> >
> > +static void do_qmp_switch_mode(Monitor *mon, const QDict *qdict,
> > + QObject **ret_data)
> > +{
> > + const char *mode;
> > +
> > + if (!monitor_ctrl_mode(mon)) {
> > + return;
> > + }
>
> So the command "qmp_switch_mode" is available in the human monitor, but
> does nothing?
>
> What about a flag "QMP only?"
Seems reasonable, I only have to check if the work it requires is
related to this series.