[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API |
Date: |
Sun, 07 Feb 2010 15:26:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 02/07/2010 03:51 PM, Jan Kiszka wrote:
>> Avi Kivity wrote:
>>
>>> On 02/03/2010 10:53 AM, Jan Kiszka wrote:
>>>
>>>> This grand cleanup drops all reset and vmsave/load related
>>>> synchronization points in favor of four(!) generic hooks:
>>>>
>>>> - cpu_synchronize_all_states in qemu_savevm_state_complete
>>>> (initial sync from kernel before vmsave)
>>>> - cpu_synchronize_all_post_init in qemu_loadvm_state
>>>> (writeback after vmload)
>>>> - cpu_synchronize_all_post_init in main after machine init
>>>> - cpu_synchronize_all_post_reset in qemu_system_reset
>>>> (writeback after system reset)
>>>>
>>>> These writeback points + the existing one of VCPU exec after
>>>> cpu_synchronize_state map on three levels of writeback:
>>>>
>>>> - KVM_PUT_ASYNC_STATE (during runtime, other VCPUs continue to run)
>>>>
>>>>
>>> Wouldn't that be SYNC_STATE (state that is modified by the current vcpu
>>> only)?
>>>
>> It's async /wrt other VCPUs. They continue to run and may interact with
>> this VCPU while updating its state.
>>
>
> Well, to me it makes more sense to name them from the point of view of
> the vcpu that is doing the update.
I'm open for a better name - except for "sync" as writebacks are always
synchronous from the POV of the modified VCPU. Is KVM_PUT_RUNTIME_STATE
clearer?
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 21/21] qemu-kvm: Bring qemu_init_vcpu back home, (continued)
- [Qemu-devel] [PATCH v2 21/21] qemu-kvm: Bring qemu_init_vcpu back home, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 17/21] qemu-kvm: Use VCPU event state for reset and vmsave/load, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 15/21] qemu-kvm: Clean up mpstate synchronization, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 12/21] qemu-kvm: Use upstream kvm_vcpu_dirty, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 19/21] qemu-kvm: Clean up KVM's APIC hooks, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 13/21] qemu-kvm: Use upstream guest debug code, Jan Kiszka, 2010/02/03
- [Qemu-devel] [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API, Jan Kiszka, 2010/02/03
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code, Marcelo Tosatti, 2010/02/03
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code, Gleb Natapov, 2010/02/07