[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host bridge
|
From: |
Blue Swirl |
|
Subject: |
[Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host bridge. |
|
Date: |
Mon, 8 Feb 2010 19:29:32 +0200 |
On Mon, Feb 8, 2010 at 8:45 AM, Isaku Yamahata <address@hidden> wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().
Bridge header type in qdev info is needed so that the write masks are
correct. Otherwise the masks make for example PCI_SECONDARY_BUS
readonly. But the device uses PCI_HEADER_TYPE_NORMAL. So both are
correct.