[Qemu-devel] Re: [PATCH 00/10] PPC NewWorld fixery v4

[Alexander Graf]

On 09.02.2010, at 21:39, Michael S. Tsirkin wrote:

> On Tue, Feb 09, 2010 at 09:37:18PM +0100, address@hidden wrote:
>> On Tue, Feb 09, 2010 at 10:30:19PM +0200, Michael S. Tsirkin wrote:
>>> On Tue, Feb 09, 2010 at 07:26:45PM +0100, Alexander Graf wrote:
>>>> 
>>>> Am 09.02.2010 um 18:01 schrieb "Michael S. Tsirkin" <address@hidden>:
>>>> 
>>>>> On Tue, Feb 09, 2010 at 05:37:00PM +0100, Alexander Graf wrote:
>>>>>> I'm trying to get the PPC64 system emulation target working finally.
>>>>>> While doing so, I ran into several issues, most related to PCI this  
>>>>>> time.
>>>>>> 
>>>>>> This patchset fixes all the PCI config space access and PCI interrupt
>>>>>> mapping issues I've found on PPC64. Using this and a patched OpenBIOS
>>>>>> version, I can successfully access IDE devices and was booting a  
>>>>>> guest
>>>>>> into the shell from IDE using serial console.
>>>>> 
>>>>> Trying to apply these I run into:
>>>>> 
>>>>> Applying: PPC: Make interrupts work
>>>>> /scm/qemu/.git/rebase-apply/patch:27: trailing whitespace.
>>>>> 
>>>>> /scm/qemu/.git/rebase-apply/patch:29: trailing whitespace.
>>>>> 
>>>>> warning: 2 lines add whitespace errors.
>>>>> Applying: PPC: tell the guest about the time base frequency
>>>>> /scm/qemu/.git/rebase-apply/patch:83: new blank line at EOF.
>>>>> +
>>>>> warning: 1 line adds whitespace errors.
>>>>> 
>>>>> Could you address these please?
>>>> 
>>>> git-am should take care of them, no?
>>>> 
>>>> Alex
>>> 
>>> It doesn't fix them, just complains.
>>> 
>> 
>> --whitespace=strip
> 
> Ah, ok. Anyway I prefer patch author to fix these up in source, rather
> then rely on tools.

What do we have tools for then? :)

Alex