[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

[Amit Shah]

On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote:
> On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote:
> > On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> > > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> > > serial devices declare MULTIPORT feature.
> > > To allow 0.12 compatibility, we should clear this when
> > > max_nr_ports is 1.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > 
> > Acked-by: Amit Shah <address@hidden>
> > 
> > A couple more patches are needed to introduce a 0.12 machine type and
> > default to 1 max_nr_ports for machine types < 0.13, which I'll be
> > sending shortly.
> 
> Note that we also need to fill in virtio feature bits for the rest of
> devices, per machine type.  Care to deal with it?

Yes, that has to be done (and at least for s390 and ppc for
virtio-serial). I've not yet seen how they work, but they should be
similar to pc (if at all they have similar versioning support).

                Amit