[Qemu-devel] Re: [PATCH 3/6] tcg: Optional target implementation of ANDC.

[Richard Henderson]

On 02/17/2010 10:34 AM, Blue Swirl wrote:
> On Wed, Feb 17, 2010 at 12:10 AM, Richard Henderson <address@hidden> wrote:
>> Previously ANDC was always implemented by tcg-op.h with
>> an explicit NOT opcode.  Allow a target implementation.
> 
> I think the convention is to add commented out #defines or #undefs for
> all targets, like sparc in bswap case:
> //#define TCG_TARGET_HAS_bswap32_i32
> //#define TCG_TARGET_HAS_bswap64_i64
> or mips:
> #undef TCG_TARGET_HAS_bswap32_i32
> #undef TCG_TARGET_HAS_bswap16_i32

Apparently that was only done for bswap, because there's a lot of 
optional opcodes that are missing everywhere.  I suppose I could
add those as a separate patch.


r~