[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block |
Date: |
Mon, 22 Feb 2010 09:54:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 |
Am 20.02.2010 02:49, schrieb Juan Quintela:
> Anthony Liguori <address@hidden> wrote:
>> On 02/15/2010 10:19 AM, Kevin Wolf wrote:
>>> The current implementation of alloc_refcount_block and grow_refcount_table
>>> has
>>> fundamental problems regarding error handling. There are some places where
>>> an
>>> I/O error means that the image is going to be corrupted. I have found that
>>> the
>>> only way to fix this is to completely rewrite the thing.
>>>
>>> Just sending as an RFC to the list hasn't generated a lot of comments (to be
>>> precise, not a single one). This is a critical part of qcow2 and needs
>>> reviews.
>>> So let's try it another way: People in CC, please give it a review. Sooner
>>> or
>>> later some of you will need to do so anyway.
>>>
>>
>> Should I apply this series? I still don't see any review comments.
>
> I sent review comments on the 18th. I expect Kevin to address them. I
> talked with him on irc while doing the review (i.e. he knows about
> them).
I was hoping for more comments as there were three more people in the CC
list. But looks like they prefer reviewing the patches downstream. I'm
going to send a v2 which addresses only your comments if I don't get any
more comments soon.
Kevin