Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

[Alexander Graf]

Blue Swirl wrote:
> Thanks, applied.
>   

This patch breaks building on ppc32. Reverting it makes it compile again:

In file included from /suse/agraf/git/qemu/tcg/tcg.c:158:
/suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error:
‘INDEX_op_qemu_ld32s’ undeclared here (not in a function)


Alex

> On 2/20/10, Jay Foad <address@hidden> wrote:
>   
>> On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the
>>  following assertion failure:
>>
>>  qemu-alpha: tcg/tcg.c:1055:
>>  tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed.
>>
>>  Signed-off-by: Jay Foad <address@hidden>
>>  ---
>>   tcg/tcg-opc.h |    5 -----
>>   1 files changed, 0 insertions(+), 5 deletions(-)
>>
>>  diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
>>  index 89db3b4..838f1f4 100644
>>  --- a/tcg/tcg-opc.h
>>  +++ b/tcg/tcg-opc.h
>>  @@ -224,11 +224,6 @@ DEF2(qemu_ld32u, 1, 1, 1, TCG_OPF_CALL_CLOBBER |
>>  TCG_OPF_SIDE_EFFECTS)
>>   DEF2(qemu_ld32u, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
>>   #endif
>>   #if TARGET_LONG_BITS == 32
>>  -DEF2(qemu_ld32s, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
>>  -#else
>>  -DEF2(qemu_ld32s, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
>>  -#endif
>>  -#if TARGET_LONG_BITS == 32
>>   DEF2(qemu_ld64, 2, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
>>   #else
>>   DEF2(qemu_ld64, 2, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
>>
>>
>>
>>     
>
>
>