[Qemu-devel] Serial: not checking (lsr & UART_LSR_THRE) in IER and not setting thr_ipending (Was Re: Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1)

[Roy Tam]

2010/2/23 Roy Tam <address@hidden>:
> 2010/2/23 Roy Tam <address@hidden>:
>> 2010/2/23 Roy Tam <address@hidden>:
>>> Hi all,
>>>
>>> This is an very old regression that DOSPlus 1.2-je5 boots in QEMU
>>> 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now.
>>>
>>> Floppy Disk Image:
>>> http://roy.reactos.me:9088/files/dp12je5.zip
>>>
>>
>> OK r1049 breaks booting DOSPlus. Is it really fix the serial interrupt issue?
>> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=60e336dbb837ef4d5053433f9ee391feb102be36
>>
>
> Comment out "s->thr_ipending = 1;" in "if (s->lsr & UART_LSR_THRE)"
> seems fix this issue.
>

bochs implementation doesn't check for (lsr & UART_LSR_THRE) in
IER(addr&7 == 1), I think we need not check for them and setting
thr_ipending. Any serial experts here?