[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v3 04/10] qemu-kvm: Clean up mpstate synchroniza
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v3 04/10] qemu-kvm: Clean up mpstate synchronization |
Date: |
Thu, 25 Feb 2010 01:02:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Marcelo Tosatti wrote:
> On Wed, Feb 24, 2010 at 03:17:52PM +0100, Jan Kiszka wrote:
>> Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86,
>> properly synchronize with halted in the accessor functions.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
>> @@ -1290,6 +1318,7 @@ int kvm_arch_init_vcpu(CPUState *cenv)
>> #ifdef KVM_EXIT_TPR_ACCESS
>> kvm_tpr_vcpu_start(cenv);
>> #endif
>> + kvm_reset_mpstate(cenv);
>> return 0;
>> }
>>
>> @@ -1363,15 +1392,10 @@ void kvm_arch_cpu_reset(CPUState *env)
>> {
>> kvm_arch_reset_vcpu(env);
>> kvm_put_vcpu_events(env);
>> - if (!cpu_is_bsp(env)) {
>> - if (kvm_irqchip_in_kernel()) {
>> -#ifdef KVM_CAP_MP_STATE
>> - kvm_reset_mpstate(env);
>> -#endif
>> - } else {
>> - env->interrupt_request &= ~CPU_INTERRUPT_HARD;
>> - env->halted = 1;
>> - }
>> + kvm_reset_mpstate(env);
>> + if (!cpu_is_bsp(env) && !kvm_irqchip_in_kernel()) {
>> + env->interrupt_request &= ~CPU_INTERRUPT_HARD;
>> + env->halted = 1;
>> }
>> }
>
> Why are these two needed? Now that initialization of mp_state
> happens via synchronize_state(init/reset) -> arch_load_regs?
Maybe correct. env->halted is also reset on load, not sure about the
interrupt_request reset impact yet. This is (or at least was) hairy
stuff, /me has to sleep about it again.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 02/10] qemu-kvm: Rework VCPU state writeback API, (continued)
- [Qemu-devel] [PATCH v3 02/10] qemu-kvm: Rework VCPU state writeback API, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 09/10] qemu-kvm: Move kvm_set_boot_cpu_id, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 10/10] qemu-kvm: Bring qemu_init_vcpu back home, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 08/10] qemu-kvm: Clean up KVM's APIC hooks, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 06/10] qemu-kvm: Use VCPU event state for reset and vmsave/load, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 05/10] KVM: x86: Restrict writeback of VCPU state, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v3 04/10] qemu-kvm: Clean up mpstate synchronization, Jan Kiszka, 2010/02/24
- [Qemu-devel] [PATCH v4 04/10] qemu-kvm: Clean up mpstate synchronization, Jan Kiszka, 2010/02/25
- [Qemu-devel] [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Marcelo Tosatti, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Marcelo Tosatti, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Marcelo Tosatti, 2010/02/24
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/02/25
- [Qemu-devel] Re: [PATCH v3 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Marcelo Tosatti, 2010/02/25