[Qemu-devel] Re: [PATCH] adding helper pci functions

[Juan Quintela]

Gerd Hoffmann <address@hidden> wrote:
> From: Izik Eidus <address@hidden>
>
> Signed-off-by: Izik Eidus <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/pci.h |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci.h b/hw/pci.h
> index 37ebdc4..20c670e 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -301,11 +301,29 @@ pci_config_set_device_id(uint8_t *pci_config, uint16_t 
> val)
>  }
>  
>  static inline void
> +pci_config_set_revision(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_REVISION_ID], val);
> +}
> +
> +static inline void
>  pci_config_set_class(uint8_t *pci_config, uint16_t val)
>  {
>      pci_set_word(&pci_config[PCI_CLASS_DEVICE], val);
>  }
>  
> +static inline void
> +pci_config_set_prog_interface(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_CLASS_PROG], val);
> +}
> +
> +static inline void
> +pci_config_set_interrupt_pin(uint8_t *pci_config, uint8_t val)
> +{
> +    pci_set_byte(&pci_config[PCI_INTERRUPT_PIN], val);
> +}
> +
>  typedef int (*pci_qdev_initfn)(PCIDevice *dev);
>  typedef struct {
>      DeviceInfo qdev;

mst had some reservations abotu this functions, but I have forgotten.

mst can you comment again?

Later, Juan.