|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH] qdev: Catch attempt to attach more than one device to a netdev |
Date: | Fri, 26 Feb 2010 11:05:52 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 |
On 02/26/10 10:30, Markus Armbruster wrote:
This made a lot of sense if each parser threw largely different errors. Which isn't the case: we have one so far ("failed to parse"), and we just encountered a use for a second.
There are actually three: parse error, not found (netdev=<does-not-exist>) and busy (netdev=<already-in-use>).
But, yes, given the small number of error cases it makes sense to generate the error one layer up and not in the parsers themself.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |