|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH 4/4] kbd keds: vnc |
Date: | Fri, 26 Feb 2010 17:05:22 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 |
Hi,
+ int caps, num;I think it is clearer to use a bool. bool caps = ledstate& QEMU_CAPS_LOCK_LED;
Indeed.
+ if (vs->modifiers_state[0x3a] != caps) { + vs->modifiers_state[0x3a] = caps;modifiers_state type needs to go from uint8_t to bool. It simplifies lots of !!foo around. But the change is independent of this series.
But mixing uin8_t and bool doesn't look sane to me. So I think I stay with uin8_t to match modifiers_state type.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |