qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 15/48] error: Don't abuse qemu_error() for n


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH RFC 15/48] error: Don't abuse qemu_error() for non-error in qdev_device_help()
Date: Fri, 26 Feb 2010 16:44:53 -0300

On Wed, 24 Feb 2010 18:55:27 +0100
Markus Armbruster <address@hidden> wrote:

> qdev_device_help() prints device information with qemu_error().  A
> later commit will make qemu_error() print additional stuff that is
> only appropriate for proper errors, and then this will break.  Use
> error_printf() instead.

 Aren't you abusing the error function just like the current code? Also,
I think that this information should be printed to stdout.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]