Re: [Qemu-devel] [PATCH RFC 11/48] error: Move qemu_error & friends into their own header

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Wed, 24 Feb 2010 18:55:23 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  hw/scsi-bus.c     |    2 +-
>>  hw/scsi-disk.c    |    3 +--
>>  hw/scsi-generic.c |    1 +
>>  hw/usb-serial.c   |    1 +
>>  hw/virtio-net.c   |    1 +
>>  hw/virtio-pci.c   |    2 +-
>>  monitor.h         |    1 +
>>  net/dump.c        |    1 +
>>  net/socket.c      |    2 +-
>>  net/tap-linux.c   |    1 +
>>  net/tap.c         |    1 +
>>  qemu-config.c     |    1 +
>>  qemu-error.h      |   12 ++++++++++++
>>  qemu-tool.c       |    2 +-
>>  qerror.c          |    2 +-
>>  sysemu.h          |    8 --------
>>  16 files changed, 26 insertions(+), 15 deletions(-)
>>  create mode 100644 qemu-error.h
>
>  Minor: isn't this change related to patch 02/48? I would merge them or
> move this one closer to 02.

I went for minimal patches, as close to their motivation as possible.  I
kept these two separate, because in each of them the code motion is a
bit more obvious than it would be in a merged patch.

01-02/48 are motivated by the desire to keep general error handling out
of a specific customer, the monitor.  I could move it down some, say
between 9/48 and 10/48.

11/48 is motivated by the desire not to further pollute sysemu.h with
the new error stuff, which starts in 12/48.  I could squash it into
02/48.

I like it the way it is well enough, but I'm not particular about it, so
if you really prefer one of the above moves or squashes, let me know.