Re: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

[Gerd Hoffmann]

On 03/03/10 19:53, Stefan Weil wrote:
> This would indeed simplify the code.
>
> Although I don't like tricky programming like DO_UPCAST
> (because I saw too much code where tricky programming
> was faulty programming),

Yea, when coding C++ in C you need little tricks now and then ;)

You need that in one place only though, nic_init() can store a pointer 
in EEPRO100State and everybody can take the direct route then ...

> > > qdev has aliases. You can add .qdev.alias = "eepro100" to one of the
> > > variants, then the eepro100 name will work as well.
>
> Good idea. To keep the number of aliases small, I plan to
> add only one or two aliases: e100 (eepro100 only if a second
> alias is possible).

You can have one alias only.

> Why? e100 is the current linux driver name.

Reasonable choice, lines up with e1000.

> eepro100 was the former linux driver name.

And leaked into a bunch of places (like qemu source code) because of 
that.  Probably only developers recognize the name though.

> The marketing name was Intel EtherExpress Pro 100.
> I agree that it would help people to see this name,
> so I suggest adding it to qemu-doc.texi.

Maybe .desc too ?

cheers,
  Gerd