[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/10] cow: return errno instead of -1
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 01/10] cow: return errno instead of -1 |
Date: |
Thu, 4 Mar 2010 10:00:30 +0100 |
Remove not needed ret = 0 assignment.
Signed-off-by: Juan Quintela <address@hidden>
---
block/cow.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 3733385..97e9745 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -224,7 +224,7 @@ static int cow_create(const char *filename,
QEMUOptionParameter *options)
cow_fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
if (cow_fd < 0)
- return -1;
+ return -errno;
memset(&cow_header, 0, sizeof(cow_header));
cow_header.magic = cpu_to_be32(COW_MAGIC);
cow_header.version = cpu_to_be32(COW_VERSION);
@@ -251,7 +251,7 @@ static int cow_create(const char *filename,
QEMUOptionParameter *options)
cow_header.size = cpu_to_be64(image_sectors * 512);
ret = qemu_write_full(cow_fd, &cow_header, sizeof(cow_header));
if (ret != sizeof(cow_header)) {
- ret = -1;
+ ret = -errno;
goto exit;
}
@@ -262,7 +262,6 @@ static int cow_create(const char *filename,
QEMUOptionParameter *options)
goto exit;
}
- ret = 0;
exit:
close(cow_fd);
return ret;
--
1.6.6.1
- [Qemu-devel] [PATCH v2 00/10] FORTIFY_SOURCE followup, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 02/10] slirp: check system() success, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 01/10] cow: return errno instead of -1,
Juan Quintela <=
- [Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 06/10] vmdk: make vmdk_snapshot_create return -errno, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 07/10] vmdk: fix double free, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 08/10] vmdk: share cleanup code, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 09/10] block: print errno on error, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 10/10] documentation: qemu_write_full don't work with non-blocking fd's, Juan Quintela, 2010/03/04